Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dodal 846 device factory support for ophyd v1 #743

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jan 13, 2025

This is part of

This PR updates mx-bluesky to work with changes introduced in dodal PR

which adds support for ophyd v1 devices to device_factory

This PR builds on mx-bluesky PR:

@rtuck99 rtuck99 force-pushed the dodal_846_device_factory_support_for_ophyd_v1 branch from 1420d00 to bd85482 Compare January 13, 2025 14:16
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (e31c703) to head (bf4f180).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files         101      101           
  Lines        6970     6970           
=======================================
  Hits         6065     6065           
  Misses        905      905           
Components Coverage Δ
i24 SSX 72.84% <ø> (ø)
hyperion 96.55% <100.00%> (ø)
other 96.58% <ø> (ø)

@rtuck99 rtuck99 requested a review from shihab-dls January 15, 2025 11:05
@rtuck99 rtuck99 force-pushed the dodal_846_update_mx_beamlines_to_use_device_factory branch 2 times, most recently from 33b17f6 to 68bb897 Compare January 28, 2025 17:45
@rtuck99 rtuck99 force-pushed the dodal_846_device_factory_support_for_ophyd_v1 branch from bd85482 to cf22363 Compare January 29, 2025 10:44
@rtuck99 rtuck99 force-pushed the dodal_846_update_mx_beamlines_to_use_device_factory branch from 68bb897 to 28f6ac7 Compare January 29, 2025 15:19
Base automatically changed from dodal_846_update_mx_beamlines_to_use_device_factory to main January 29, 2025 15:35
@rtuck99 rtuck99 force-pushed the dodal_846_device_factory_support_for_ophyd_v1 branch from cf22363 to bf4f180 Compare January 29, 2025 16:34
@rtuck99 rtuck99 merged commit adc54b2 into main Jan 30, 2025
22 checks passed
@rtuck99 rtuck99 deleted the dodal_846_device_factory_support_for_ophyd_v1 branch January 30, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants